Open RahavLussato opened 6 years ago
the tests failed because of "Uh oh, you've run out of minutes! Please visit https://saucelabs.com/pricing to purchase a subscription."
Merging #31 into master will decrease coverage by
0.74%
. The diff coverage is93.33%
.
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 99.01% 98.27% -0.75%
==========================================
Files 1 1
Lines 102 116 +14
==========================================
+ Hits 101 114 +13
- Misses 1 2 +1
Impacted Files | Coverage Δ | |
---|---|---|
lib/index.js | 98.27% <93.33%> (-0.75%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bac8a65...3ee85b5. Read the comment docs.
Hey @RahavLussato - thanks for the PR! Sorry for the delay on my reply here, but I'll be helping with getting this PR out the door! Thanks for adding in tests, I just have a last few questions for clarity to validate this change:
Thanks so much, just ping me when you reply and I'll hop right in to help get this done!
Hi @Peripheral1994
if (window.analytics) {
window.analytics.user().reset();
if (window.Intercom) {
window.Intercom('shutdown');
}
window.analytics.page('_boot');
}
basically, it gives you the ability to reset this.booted
on logout.
Awesome, got it @RahavLussato . I've tested it and it definitely seems to work with the code as-written. My only concern would be that we'd have to require each individual customer to implement this custom behavior manually, which doesn't make for a great user experience. I'm thinking that this should actually be something that lives within the settings in the Segment UI, I'll take a moment to think of a solution we can make on our end that would hopefully make this a much easier solution on the user side!
Any news on this? We've been struggling with the problem of Intercom not logging out on .reset()
hi @Peripheral1994 is there any updates? do you need my help with this?
Hi @tobold and @RahavLussato - Sara from Segment following up here. Pardon our delay in providing an update.
After some additional internal discussion on this matter, we've concluded we're not yet ready to move on implementing these changes. We'll need to take some extra time to make sure we have a solution that we're confident will work for all users, ideally without requiring custom implementation. I don't have a timeline to share on that just yet, but will keep this thread updated.
Thanks for your input here, and we appreciate your patience!
Hi @srthurman, I understand the needs for seamless change and integration but the part that require from the user to have the custom code is only related to point 3
when the user data is rested intercom integration not doing shutdown and boot again with the new data.
the other 2 fixes another big issue related to the user data that I think it may worth to have it as soon as you can.
hi, @srthurman we are waiting for a long time for this, what is the status for that. meantime it's requiring from me to work with a fork wich much harder to maintain. this PR is fixing 2 critical bugs:
Hi @RahavLussato - thanks for checking in. I still don't have a timeline to share on this update based on other priorities the team is working on at the moment, but will be sure to update here when I do.
fix #30 another thing is that i think segment intercom integration should check if the user is already identified and initialize with the identified user, currently i don't see how to do it since the user_hash is not persistent.
EDIT: after digging inside the lib i can see that we can also solve #6 as part of this. the issue is that the intercom integration is not sync with segment user data on multiple cases:
to solve all of this i added new logic that get the user data on each page call in order to be synced with segment user data and also i've added new boot mode (to solve #6) that should be used like that: