search

segment-integrations / analytics.js-integration-kissmetrics

The Kissmetrics analytics.js integration.
https://segment.com/docs/integrations/kissmetrics/
MIT License
0 stars 2 forks source link

flatten nested obj #10

Closed hankim813 closed 9 years ago

hankim813 commented 9 years ago

To achieve parity between server side integration PR

https://github.com/segmentio/integration-kissmetrics/pull/12

which flattens objects and stringifies arrays inside nested objects.

@f2prateek

f2prateek commented 9 years ago

LGTM, i'd add an extra level of depth in the test calls to test the behaviour better.

hankim813 commented 9 years ago

@f2prateek good call. added that