search

segment-integrations / analytics.js-integration-kissmetrics

The Kissmetrics analytics.js integration.
https://segment.com/docs/integrations/kissmetrics/
MIT License
0 stars 2 forks source link

The integration is overwriting an asynchronous queue #17

Open lucasoptimizely opened 8 years ago

lucasoptimizely commented 8 years ago

@hankim813 The Kissmetrics integration is ignoring all information set before Segment is loaded by executing this line in initialize: window._kmq = []; here: https://github.com/segment-integrations/analytics.js-integration-kissmetrics/blob/master/lib/index.js#L50

This breaks the Optimizely/Kissmetrics integration. Is it possible to fix this?

hankim813 commented 8 years ago

Ahhh so we should be doing window._kmq = window._kmq || [];?

lucasoptimizely commented 8 years ago

To be honest: I think that should work but I haven't read through the entire code of the integration. I was just looking for scripts that were overwriting the _kmq variable and found this line.

On Wed, Jun 15, 2016 at 8:27 PM, Han notifications@github.com wrote:

Ahhh so we should be doing window._kmq = window._kmq || [];?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/segment-integrations/analytics.js-integration-kissmetrics/issues/17#issuecomment-226379336, or mute the thread https://github.com/notifications/unsubscribe/ADv9sWnYpVwJTkv7Tqt496VUxPSv0NNtks5qMMKagaJpZM4I2-pD .

Lucas Swartsenburg Partner Solution Architect | Optimizely, Inc. http://www.optimizely.com/ lucas@optimizely.com | (1) 415 996 97 96 We're hiring! http://www.optimizely.com/jobs Talk to me if you're interested!

chriso commented 8 years ago

This was fixed in d1e7b30834656298b4b6ee1a0eabf55c5653a69a.

hankim813 commented 8 years ago

@lucasoptimizely yep will close this once the fix is deployed. Right now we're undergoing a rollout of new version of analytics.js so I'm hoping to be able to release the new KM fixes/changes sometime next week

SegmentDestinationsBot commented 4 years ago

Hi @lucasoptimizely, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!

For more information, see README.md.