segment-integrations / analytics.js-integration-kissmetrics

The Kissmetrics analytics.js integration.
https://segment.com/docs/integrations/kissmetrics/
MIT License
0 stars 2 forks source link

Adjust initialization behavior #18

Closed njm closed 8 years ago

njm commented 8 years ago

This makes two changes to initialization for the integration:

hankim813 commented 8 years ago

The assumePageview is generally used when partner libraries internally tracks a page call upon its own initialization. We do this so that we don't double count pageviews for integrations that behave that way. But looking at this, it looks like we're calling self.trackPage() in the callback of the load function... which kind of defeats the purpose of the assumePageview :/

Anyways, this lgtm! We're going through some analytics.js migration this week so we won't be able to deploy this until sometime next week.

Thanks for submitting the PRs! @njm