search

segment-integrations / analytics.js-integration-kissmetrics

The Kissmetrics analytics.js integration.
https://segment.com/docs/integrations/kissmetrics/
MIT License
0 stars 2 forks source link

Discard nested undefined values #19

Closed njm closed 8 years ago

njm commented 8 years ago

This fixes a bug in the clean function. undefined values would pass through the existence test, and ultimately fail upon invocation of a missing toString method. This broadens the initial check to discard undefined values as well as null.

codecov-io commented 8 years ago

Current coverage is 98.42% (diff: 100%)

Merging #19 into master will not change coverage

@@             master        #19   diff @@
==========================================
  Files             1          1          
  Lines           127        127          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            125        125          
  Misses            2          2          
  Partials          0          0

Powered by Codecov. Last update 7579298...eddc5c9

f2prateek commented 8 years ago

lgtm

njm commented 8 years ago

Thanks @f2prateek. Can you offer an ETA for deployment?

hankim813 commented 8 years ago

@njm will deploy this first thing Tuesday since Monday is a holiday! (we don't deploy code on fridays usually)

hankim813 commented 8 years ago

@njm deployed!

njm commented 8 years ago

Great, thanks @hankim813.