search

segment-integrations / analytics.js-integration-sentry

The Sentry analytics.js integration.
https://segment.com/docs/integrations/sentry/
MIT License
3 stars 7 forks source link

Add option for custom version property - EPD-1082 #25

Closed Peripheral1994 closed 7 years ago

Peripheral1994 commented 7 years ago

This adds the ability for users to specify a global property that can be used to dynamically determine the release version with that property, instead of manually changing it in Segment's nor Sentry's UI.

If the custom property exists on the window, and that resulting value is truthy, then it will be used in place of the release option.

CC @hankim813 @ladanazita

hankim813 commented 7 years ago

@Peripheral1994 nice dude, had a suggestion for the test you wrote.

otherwise lgtm -- don't forget the release commit!