segment-integrations / analytics.js-integration-sentry

The Sentry analytics.js integration.

https://segment.com/docs/integrations/sentry/

MIT License

3 stars 7 forks source link

Use raven-js@3.24.2 #30

Open jpreynat opened 6 years ago

jpreynat commented 6 years ago

This PR was made mainly to take advantage of getsentry/raven-js#1253 when parsing non-Error like Objects that is a big improvement for errors debugging in Sentry.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9357749). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #30   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     25           
  Branches          ?      0           
=======================================
  Hits              ?     25           
  Misses            ?      0           
  Partials          ?      0

Impacted Files	Coverage Δ
lib/index.js	`100% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9357749...289e8b9. Read the comment docs.

miketheman commented 6 years ago

https://github.com/getsentry/raven-js/releases/tag/3.24.2 was released - let's get that one?

mshwery commented 6 years ago

Looks like the failure in CircleCI was related to rate-limited use of saucelabs for browser testing:

Uh oh, you've run out of minutes!
Please visit https://saucelabs.com/pricing to purchase a subscription.

Can someone with auth trigger a rebuild? Would love to see this get pushed through. Many older .NET projects can't use the current v3.17.0 Sentry integration version due to 'use strict' causing FireFox and IE to throw exceptions because many old .NET libraries use arguments.callee.

jesseforrest commented 6 years ago

Any update on getting the latest SDK from Sentry into Segment?

SegmentDestinationsBot commented 5 years ago

Hi @jpreynat, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!

For more information, see README.md.