segmentio / analytics-ios

The hassle-free way to integrate analytics into any iOS application.
https://segment.com/libraries/ios
MIT License
402 stars 334 forks source link

Module imports need to be removed for Objective-C++ compatibility (React Native 0.68+) #1036

Open shamilovtim opened 2 years ago

shamilovtim commented 2 years ago

The module imports are unnecessary and they create complications for Objective-C++:

Screen Shot 2022-06-14 at 7 01 00 PM

If users add the flags for Objective-C++ modules it will break other dependencies in their projects. Could you please remove the module imports and use the header system like the rest of these files are already using?

Related: https://github.com/firebase/FirebaseUI-iOS/issues/875 https://github.com/facebook/react-native/issues/33692 https://github.com/invertase/react-native-firebase/pull/6223

WYZEYaolongZhu commented 2 years ago

image