search

segmentio / analytics-ios

The hassle-free way to integrate analytics into any iOS application.
https://segment.com/libraries/ios
MIT License
402 stars 334 forks source link

Remove unused SegmentTestsTVOS scheme #1038

Closed pietropizzi closed 1 year ago

pietropizzi commented 2 years ago

What does this PR do?

It removes a scheme that seems to not be used anywhere.

Any background context you want to provide?

It was causing issues when building with Carthage on Xcode 14, preventing successful linking against the Segment SDK on Xcode 14.

pietropizzi commented 2 years ago

Hey @bsneed @alanjcharles @prayansh (tagging recent contributors),

Could you have a look at this and maybe merge it?

The tests are failing but there must be something wrong with the test setup when I briefly looked at the build output.

Thanks 🙏

bsneed commented 2 years ago

Hi @pietropizzi. I'd recommend upgrading to analytics-swift if possible. We're planning on deprecating this library relatively soon and phasing out Carthage support entirely.

pietropizzi commented 2 years ago

Hi @pietropizzi. I'd recommend upgrading to analytics-swift if possible. We're planning on deprecating this library relatively soon and phasing out Carthage support entirely.

Happy to use SPM. analytics-swift unfortunately does not support all the features we are using.

Is it not possible for you to merge the PR and release a new version since this codebase is not deprecated yet.

bsneed commented 2 years ago

@pietropizzi what features are missing from analytics-swift?

ozgur commented 2 years ago

@bsneed some of the customers like us don't have the luxury to transition to swift library at this point. This PR is fixing the build error in Xcode 14 so I'd be appreciated if you can merge it soon.

https://github.com/segmentio/analytics-ios/issues/1042

BudhirajaRajesh commented 2 years ago

If we can't remove it, can we make these schemes unshared. This will fix issue as well.

RushanB commented 2 years ago

After further research this is an issue on Carthage side as well, but who knows when that will get fixed.

Reference: https://github.com/Carthage/Carthage/pull/3293

pietropizzi commented 2 years ago

@bsneed As you see we are not the only ones who can't easily switch over.

At this point I really don't understand your reluctance to merge this PR and release a version 4.1.7. You have an open source repo that has not been deprecated, the work is already done for you.

Please merge and release this.

NicolasEymael commented 1 year ago

up! the issue on Carthage was fixed https://github.com/Carthage/Carthage/pull/3293

bsneed commented 1 year ago

Thanks @NicolasEymael !

NicolasEymael commented 1 year ago

@bsneed shouldn't this be merged instead of closed?

bsneed commented 1 year ago

Ah, did I misunderstand? I read it as a Carthage issue got fixed so this was no longer necessary. If so, let me know and I'll reopen.

My previous questions in the thread about WHY people can't upgrade to the Swift lib are still relevant, so if anyone would like to chime in with some details that would be amazing. So far all I've seen is "missing feature(s)" but no details what that means. Afaik, there's nothing missing capabilities wise, but there are some things that are different.