Closed zikaari closed 5 months ago
Latest commit: d6caafac71ebf1b418b50cceb9dda8bc3aae8a15
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@chrisradek should we get it out of the way and link to our segment doc update PR here, so it doesn't get lost in the fray?
My docs PR was 1:1 replica of Seth's PR. Where do I explain the usage of this feature?
My docs PR was 1:1 replica of https://github.com/segmentio/segment-docs/pull/5754. Where do I explain the usage of this feature?
Do we currently explain anywhere in the docs that you can change the variable used to install analytics? I originally thought you also had to use the globalAnalyticsKey
with this feature - but looking at your test looks like that's probably not the case. So might make sense to add another section to Segment Docs on using something other than window.analytics
for snippet users.
Will add a section to the javascript, what do you think should the section be titled? "Installing Analytics under custom namespace"?
"Installing Analytics under custom namespace"
I think something like that is fine. We can always update it as well, just want to make sure we are documenting our changes - we've not always been great about that historically.
Docs are here - https://github.com/segmentio/segment-docs/pull/5949
Fixes #1014
Please refer to the original issue for more information
Docs for this feature - https://github.com/segmentio/segment-docs/pull/5949
yarn changeset
. Read about changesets here).