Fix schema filter name collision bug

segmentio / analytics-next

Segment Analytics.js 2.0

https://segment.com/docs/connections/sources/catalog/libraries/website/javascript

MIT License

385 stars 128 forks source link

Fix schema filter name collision bug #1036

Closed danieljackins closed 5 months ago

danieljackins commented 5 months ago

This PR fixes an issue with integrations containing similar names (ie. Google Analytics and Google Analytics 4) having their schema filters applied incorrectly. It updates the filters to compare the schema filter name (which uses the creation name of the integration) with the creationName field in the remote plugin.

[x] I've included a changeset (psst. run yarn changeset. Read about changesets here).

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 0d4e6a7fcc711a459e801729c47500bd57dd3eca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------------- | ----- | | @segment/analytics-next | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

silesky commented 5 months ago

@danieljackins looks good but ugh, I see a weird BK error that seems unrelated to this PR. Any idea what's going on?

danieljackins commented 5 months ago

@danieljackins looks good but ugh, I see a weird BK error that seems unrelated to this PR. Any idea what's going on?

I think buildkite is/was having some issues, I saw some others with the same problem