segmentio / analytics-next

Segment Analytics.js 2.0
https://segment.com/docs/connections/sources/catalog/libraries/website/javascript
MIT License
402 stars 136 forks source link

Fix RemotePlugins typescript type #1068

Open silesky opened 5 months ago

silesky commented 5 months ago

@chrisradek

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 62d4056f1065661706377c64dff06fc383c39db1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------- | ----- | | @segment/analytics-next | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

chrisradek commented 5 months ago

Ah, I guess we could view this as a breaking change if someone were passing in their own CDN settings (seems unlikely outside of tests though)

silesky commented 5 months ago

Ah, I guess we could view this as a breaking change if someone were passing in their own CDN settings (seems unlikely outside of tests though)

Microsoft/Typescript philosophy? Types are never breaking changes :-)