search

segmentio / analytics-python

The hassle-free way to integrate analytics into any python application.
https://segment.com/libraries/python
MIT License
240 stars 149 forks source link

Issue #344 fix tests #425

Closed nd4p90x closed 7 months ago

nd4p90x commented 8 months ago

Update the github actions to include loading of application requirements file and execute tests for each version

nd4p90x commented 8 months ago

@MichaelGHSeg Please review and confirm test action is completing after update. Thank you.

MichaelGHSeg commented 8 months ago

Looks like it's only running the 8 tests in segment/analytics/test/init.py I feel like the easiest way to do this might be to move the contents of init.py (without the hack to run other test files that doesn't seem to work) to a differently named file and make init.py blank. Some things I read said a blank init would have it run everything.

nd4p90x commented 8 months ago

@MichaelGHSeg I reformatted the test suite to conform to python 3 requirements. All tests appear to be executing as expected, however, we are receiving some errors on the oath test regarding URL and possibly other issues related to the written tests. Would you like to handle the oath test issues?

MichaelGHSeg commented 8 months ago

I'll take a look

MichaelGHSeg commented 8 months ago

OAuth is working as intended, the tests that make sure exceptions are handled are just noisy.

The utility tests seem to have what I'm guessing is a python3 problem where datetimes, exceptions, and functions aren't serializable when they once were? It ends up just leaving them out of the output and comparison datasets so it still passes, but we could clean that up.

nd4p90x commented 7 months ago

@MichaelGHSeg Removal of that requirement you suggested worked, ready to move forward.

Thanks,