segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.
https://segment.com/docs/sources/mobile/react-native/
MIT License
360 stars 185 forks source link

Crash in older version of analytics-react-native #857

Closed sushilr closed 1 year ago

sushilr commented 1 year ago

Steps to reproduce We've started seeing this crash intermittently:

java.lang.NullPointerException · Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
Utils.java:208 com.segment.analytics.internal.Utils.isEmptyOrBlank
Analytics.java:1101 com.segment.analytics.Analytics$Builder.<init>
Analytics.java:178 com.segment.analytics.Analytics.with
RNAnalyticsModule.kt:44 com.segment.analytics.reactnative.core.RNAnalyticsModule.getAnalytics
RNAnalyticsModule.kt:216 com.segment.analytics.reactnative.core.RNAnalyticsModule.setup
Method.java:-2 java.lang.reflect.Method.invoke
JavaMethodWrapper.java:372 com.facebook.react.bridge.JavaMethodWrapper.invoke
JavaModuleWrapper.java:188 com.facebook.react.bridge.JavaModuleWrapper.invoke
NativeRunnable.java:-2 com.facebook.jni.NativeRunnable.run
Handler.java:980 android.os.Handler.handleCallback
Handler.java:104 android.os.Handler.dispatchMessage

I've seen posts about this in analytics-android repo and the recommendation was to create an issue here.

We are not ready yet to migrate to 2.x. I was wondering if there's a workaround to fix this crash since it is impacting our stability numbers. Does updating the android native dependency to 4.11.3 help?

Expected behavior Does not crash

Actual behavior

sushilr commented 1 year ago

Closing since we decided to migrate to 2.x