search

segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.
https://segment.com/docs/sources/mobile/react-native/
MIT License
354 stars 181 forks source link

Peer dependency issue for Firebase plugin #880

Closed jacquesdev closed 8 months ago

jacquesdev commented 9 months ago

Summary

I've noticed that your firebase plugin you have the baked in peer dependencies: "@react-native-firebase/app": "^17.3.2", "@react-native-firebase/analytics": "^17.3.2"

Proposed Solution

Would it be possible to either not have that, or to upgrade to the 18? Technically it means, Firebase for my whole app is stuck at a level, which is around 6 months old, losing out on many of the improvements that have been made since then? I've just installed firebase 18.4.0, and segment is still happily sending events (at least there doesn't seem to be a dependency conflict). I've done that using --force, but it's a pain to have to that every time, especially if it's not really important

oscb commented 9 months ago

We pin it to a major version since new releases might break up things. But given that there's no issue happy to give it a bump.

jacquesdev commented 9 months ago

Thanks @oscb - would you like me to get in a PR for this? Are you ok with version 18.4.0 (current latest)?

oscb commented 9 months ago

@jacquesdev that would be very appreciated! latest sounds good.

jacquesdev commented 9 months ago

Added: https://github.com/segmentio/analytics-react-native/pull/883