segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.
https://segment.com/docs/sources/mobile/react-native/
MIT License
354 stars 181 forks source link

Add consent management and support for onetrust cmp #882

Closed zikaari closed 9 months ago

zikaari commented 9 months ago

This patch implements the work laid out in mobile consent management SDD.

A great starting point for reviewers to check compliance with the SDD is OneTrust.test.ts file.

oscb commented 9 months ago

🚢 I already approved but saw the Android Integration tests failing. I don't see anything in your changes that could be impacting those tests, might be just a blip in Detox. The only other possibility I can think of is if Detox has an issue with NPM 18 as I see you bumped this value, although I would be surprised if it was only impacting Android.

I just put a retry run. Let's see if that clears it. Else might require some investigation.