segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.

https://segment.com/docs/sources/mobile/react-native/

MIT License

354 stars 181 forks source link

feat: RN 0.72 Upgrade #902

Closed oscb closed 6 months ago

oscb commented 7 months ago

RN 0.72 upgrade

This is a full upgrade of the monorepo to support RN 0.72+ for testing/development.

Added another 0.73 App for testing (not working with E2E tests yet).

All devDependencies have been upgraded: Yarn, TS, Jest, ESLint, Detox, etc

Some changes:

New shared private package for holding common dev utils
E2E and Example are now split between 2 different apps
Tests are not included in the built package anymore
The E2E tests against release version of the app, also refactored not to use hacks for URL replacement but proxy options.

Known issues:

Detox is not running properly in GHA. It runs locally fine. - TSJest marks non-errors on individual packages (e.g. Argument of type lib.SegmentClient is not assignable to src.SegmentClient) due to configurations at individual level. Monorepo level testing works properly

oscb commented 6 months ago

Did upgrading detox help the e2e in ci situation?

@chrisradek sadly no, I'll try something else