Please add support for React Native 0.73 and Expo SDK 50

segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.

https://segment.com/docs/sources/mobile/react-native/

MIT License

354 stars 181 forks source link

Please add support for React Native 0.73 and Expo SDK 50 #915

Closed anojht closed 4 months ago

anojht commented 5 months ago

Please add support for React Native 0.73 and Expo SDK 50 which now defaults to Java 17 for the build environment.

analytics-react-native version: 2.15.0
Integrations versions (if used):
React Native version: 0.73
iOS or Android or both? both

Currently builds are failing due to Java version being pinned at 11:

leemhenson commented 5 months ago

~~Yeah, not working for me on Expo 50 either. This is what I see from expo prebuild~~:

expo prebuild --clean

Warning! Your git working tree is dirty.
It's recommended to commit all your changes before proceeding, so you can revert the changes made by this command if necessary.

✔ Would you like to proceed? … yes

✔ Cleared android, ios code
✔ Created native directories
✔ Updated package.json | no changes
✔ Finished prebuild
⚠️  Something went wrong running `pod install` in the `ios` directory.
Command `pod install` failed.
└─ Cause: Unable to find a specification for `sovran-react-native` depended upon by `segment-analytics-react-native`

You have either:
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Something changed somewhere and now, after completing rebuilding my node_modules and package-lock.json, I can expo prebuild successfully with Expo 50 and have been able to submit events to Segment.

catodapice commented 5 months ago

any news on this? I've RN 0.73 and still failing on Android & iOS

naleon commented 4 months ago

guys, do you have any due date for this update?

Jeecabs commented 4 months ago

In case it's helpful for anyone, I managed to resolve the Android build issues. Here's what worked for me:

I cleared the node_modules and package-lock.json, then reinstalled everything. After doing so, the builds started passing in EAS. Here are the versions of the relevant packages I used in my package.json:

{
    "react-native": "0.73.2",
    "expo": "~50.0.6",
    "expo-random": "~13.6.0",
    "@segment/analytics-react-native": "^2.18.0",
    "@segment/sovran-react-native": "^1.1.0"
}

anojht commented 4 months ago

I can confirm clearing the lock file and the node_modules directory then doing an install does indeed fix the builds on EAS.

Leaving the issue open for the maintainers to review any changes needed to properly support the new SDK.