fix: update gradle files for 0.73 support

segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.

https://segment.com/docs/sources/mobile/react-native/

MIT License

354 stars 181 forks source link

fix: update gradle files for 0.73 support #917

Closed oscb closed 4 months ago

oscb commented 4 months ago

Current lib should just work with 0.73 but taking preliminary steps to keep up to date based on the work specified here And in particular on the revised outputs of create-react-native-library CLI

Updated build.gradle and gradle.properties to match new CLI outputs
Added new AndroidManifest.xml without namespace
Added namespace in build.gradle only if Gradle 7.3+

Fixes #915

oscb commented 4 months ago

@chrisradek

Looks good to me - did you already verify this doesn't break things for react-native < 0.73?

Yes, the E2E actually tests against 0.72 I cannot build personally anything less than 0.72 due to Xcode MacOS incompatibility. Apple is also removing the capability to submit apps not built with Xcode 15 in a few months so people will be upgrading to 0.72 at least.

Also of note that we're not bumping any major versions or using any particular features of Java/gradle so people should just be able to override with lower numbers if needed just as before

oscb commented 4 months ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

oscb commented 4 months ago

:tada: This PR is included in version 2.19.0 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

oscb commented 4 months ago

:tada: This PR is included in version 1.3.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: