segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.
https://segment.com/docs/sources/mobile/react-native/
MIT License
354 stars 181 forks source link

[2.19.0] has console.log leftovers #922

Closed efstathiosntonas closed 4 months ago

efstathiosntonas commented 4 months ago

on 2.19.0 there are console.log leftovers:

https://github.com/segmentio/analytics-react-native/blob/887b23f111316e7c9ea9b33f1744e2b8a1342d0d/packages/core/src/analytics.ts#L429

https://github.com/segmentio/analytics-react-native/blob/887b23f111316e7c9ea9b33f1744e2b8a1342d0d/packages/core/src/analytics.ts#L482

and several other places inside analytics.ts

@segment+analytics-react-native+2.19.0.patch

diff --git a/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js b/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js
index 5aa112f..afc354f 100644
--- a/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js
+++ b/node_modules/@segment/analytics-react-native/lib/commonjs/analytics.js
@@ -298,7 +298,6 @@ class SegmentClient {
   }
   async process(incomingEvent) {
     const event = this.applyRawEventData(incomingEvent);
-    console.log(`Process: ${this.isReady.value}`);
     if (this.isReady.value) {
       return this.startTimelineProcessing(event);
     } else {
@@ -344,7 +343,6 @@ class SegmentClient {
    * @param isReady
    */
   async onReady() {
-    console.log(`onReady, pendingEvents=${this.store.pendingEvents.get().length}`);
     // Add all plugins awaiting store
     if (this.pluginsToAdd.length > 0 && !this.isAddingPlugins) {
       this.isAddingPlugins = true;
diff --git a/node_modules/@segment/analytics-react-native/lib/module/analytics.js b/node_modules/@segment/analytics-react-native/lib/module/analytics.js
index 45c7325..f8a0783 100644
--- a/node_modules/@segment/analytics-react-native/lib/module/analytics.js
+++ b/node_modules/@segment/analytics-react-native/lib/module/analytics.js
@@ -292,7 +292,6 @@ export class SegmentClient {
   }
   async process(incomingEvent) {
     const event = this.applyRawEventData(incomingEvent);
-    console.log(`Process: ${this.isReady.value}`);
     if (this.isReady.value) {
       return this.startTimelineProcessing(event);
     } else {
@@ -338,7 +337,6 @@ export class SegmentClient {
    * @param isReady
    */
   async onReady() {
-    console.log(`onReady, pendingEvents=${this.store.pendingEvents.get().length}`);
     // Add all plugins awaiting store
     if (this.pluginsToAdd.length > 0 && !this.isAddingPlugins) {
       this.isAddingPlugins = true;
diff --git a/node_modules/@segment/analytics-react-native/src/analytics.ts b/node_modules/@segment/analytics-react-native/src/analytics.ts
index 4a4270a..2970277 100644
--- a/node_modules/@segment/analytics-react-native/src/analytics.ts
+++ b/node_modules/@segment/analytics-react-native/src/analytics.ts
@@ -426,8 +426,6 @@ export class SegmentClient {
   async process(incomingEvent: SegmentEvent) {
     const event = this.applyRawEventData(incomingEvent);

-    console.log(`Process: ${this.isReady.value}`);
-
     if (this.isReady.value) {
       return this.startTimelineProcessing(event);
     } else {
@@ -479,9 +477,6 @@ export class SegmentClient {
    * @param isReady
    */
   private async onReady() {
-    console.log(
-      `onReady, pendingEvents=${this.store.pendingEvents.get().length}`
-    );
     // Add all plugins awaiting store
     if (this.pluginsToAdd.length > 0 && !this.isAddingPlugins) {
       this.isAddingPlugins = true;