refactor: merge sovran into core lib

segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.

https://segment.com/docs/sources/mobile/react-native/

MIT License

354 stars 181 forks source link

refactor: merge sovran into core lib #924

Closed oscb closed 2 months ago

oscb commented 4 months ago

BREAKING CHANGE: @segment/sovran-react-native is now deprecated. Remove from your dependencies. All functionality is now rolled in the core package.

Required changes:

Remove @segment/sovran-react-native from your dependencies.
iOS: If you are using trackDeeplinks or setAnonymousId from native you'll need to update the imports to

- #import <segment_analytics_react_native-Swift.h>
+ #import "SegmentAnalyticsReactNative-Swift.h"

oscb commented 3 months ago

Overall looks good, had a few minor comments.

Also wondering, do we still need to mock Sovran here:

https://github.com/segmentio/analytics-react-native/blob/7160d3d669502b390e9d6712c7db39b30c410e91/packages/shared/__mocks__/react-native.ts#L36-L40

No need for that anymore. It's part of the methods that I removed altogether