search

segmentio / analytics-react-native

The hassle-free way to add analytics to your React-Native app.
https://segment.com/docs/sources/mobile/react-native/
MIT License
367 stars 191 forks source link

Specify peer dependencies in package.json #937

Closed watadarkstar closed 5 months ago

watadarkstar commented 7 months ago

Summary

It would be nice if this library specified peer dependencies in the package.json

Proposed Solution

See example: https://github.com/watadarkstar/react-native-typing-animation/blob/18e8d6f3f051e3308acbf497fd12dd15575848ec/package.json#L41-L44

Peers should be @segment/sovran-react-native and react-native-get-random-values

i.e. 

  "peerDependencies": {
    "@segment/sovran-react-native": "*",
    "react-native-get-random-values": "*",
  }
hvardhan-unth commented 5 months ago

Peer dependencies already added.