[segmentio] Drop the event when message exceeds the maximum size

segmentio / analytics.js-integrations

Monorepo housing Segment's analytics.js integrations

https://segment.com/docs/destinations/

MIT License

119 stars 142 forks source link

Open gglavan-ellation opened 3 years ago

gglavan-ellation commented 3 years ago

Hi 👋 . Is there any reason why the segmentio integration doesn't drop the event when the message exceeds the maximum size as the analytics-ios and analytics-android SDKs do? Looking through the files it seems like this was actually considered a year ago. https://github.com/segmentio/analytics.js-integrations/blob/a33206aac3dccf6b4c5b3166a0ebdb4fd23c5e5d/integrations/segmentio/lib/index.js#L377-L378

I'm willing to open a PR if that is still considered.

gglavan-ellation commented 3 years ago