segmentio / analytics.js-integrations

Monorepo housing Segment's analytics.js integrations
https://segment.com/docs/destinations/
MIT License
119 stars 141 forks source link

[Walkme] Add bucket option #767

Closed varadarajan-tw closed 1 year ago

varadarajan-tw commented 1 year ago

What does this PR do?

Clone of https://github.com/segmentio/analytics.js-integrations/pull/759

Are there breaking changes in this PR?

No. This adds a new setting to allow customers load script from a private bucket in S3.

Testing

Any background context you want to provide? N/A Is there parity with the server-side/android/iOS integration components (if applicable)? N/A

Does this require a new integration setting? If so, please explain how the new setting works This requires a new setting called customDirectory. There is already an existing setting in partner portal with a typo called customDirecotry'. But no customer has set the value in production. So, we'll delete the setting and create a new setting calledcustomDirectory`. This is the directory from which custom implementation

Links to helpful docs and other external resources