segmentio / analytics.js-integrations

Monorepo housing Segment's analytics.js integrations
https://segment.com/docs/destinations/
MIT License
119 stars 141 forks source link

WalkMe integration broken for production environments #769

Closed mattngan closed 10 months ago

mattngan commented 1 year ago

Hi there,

I've noticed that https://github.com/segmentio/analytics.js-integrations/pull/759 introduces a bug for the WalkMe integration

We have removed the "\/" on the following line

  var env = (this.options.environment && this.options.environment.toLowerCase());

https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/walkme/lib/index.js#L41

but however left it in the checks in the if on this line:

  if (!env || env == "\/" || env == "\/production") {

https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/walkme/lib/index.js#L43

This is leading to production urls being generated differently than before leading to a AccessDenied response from WalkMe

mattngan commented 1 year ago

Pr to fix typo - https://github.com/segmentio/analytics.js-integrations/pull/771