search

segmentio / analytics_flutter

The hassle-free way to add Segment analytics to your Flutter app.
MIT License
29 stars 36 forks source link

Shouldnt `Product Clicked` event be mapped as `select_item` instead of `select_content`? #90

Closed fhdeodato closed 1 month ago

fhdeodato commented 3 months ago

Hello,

thanks for the amazing plugin =)

I was reviewing the Firebase integration and looks like the plugin translates the event Product Clicked to Firebase select_content one.

but we have a recommended events when the user clicks a product that is the select_item.

Which makes think that we should change it because, since the event is specific for "Products".

this event already exists in the firebase package

https://github.com/firebase/flutterfire/blob/master/packages/firebase_analytics/firebase_analytics/lib/src/firebase_analytics.dart#L828

Is there any reason that is mapped using the select_content? it is important to know before sending a PR

Thanks for the help

edsonjab commented 3 months ago

Hi @fhdeodato thank you for your report, looks like we have a mistake on that method, it makes sense that the Product Clicked will be select_item.