search

segmentio / chamber

CLI for managing secrets
MIT License
2.46k stars 169 forks source link

chore: Convert to log/slog #519

Open bhavanki opened 2 months ago

bhavanki commented 2 months ago

The small amount of verbose logging in the exec command has been converted to debug logging under log/slog. Accordingly, the --verbose command line flag has been deprecated in favor of the more flexible --log-level flag.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37.22%. Comparing base (22441a2) to head (768847a).

Files Patch % Lines
cmd/root.go 15.78% 16 Missing :warning:
cmd/exec.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #519 +/- ## ========================================== - Coverage 37.33% 37.22% -0.12% ========================================== Files 29 29 Lines 2646 2662 +16 ========================================== + Hits 988 991 +3 - Misses 1571 1584 +13 Partials 87 87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bhavanki commented 2 months ago

slog was introduced in Go 1.21, so this cannot be integrated yet since chamber still supports go 1.20. I'll leave this PR inactive until the 1.23 release, which is expected in August (about 2 months from now).