search

segmentio / chrome-sidebar

Easiest way to embed an iframe as a chrome extension
https://open.segment.com
227 stars 58 forks source link

Why chrome-sidebar is not a dependency of github-trending? #2

Closed yxliang01 closed 7 years ago

yxliang01 commented 7 years ago

I guess the reason why you didn't add it is because you have a globally linked chrome-sidebar? However, in this way, people who just want to try your github-trend example will not be able to just do npm install.

Thanks

fouad commented 7 years ago

oops! it should be (previously had it require ../../../dist and forgot to run npm install again)

yxliang01 commented 7 years ago

I would recommend you to have a separate repo for the example though. It's easier to try this thing I would say.

Thanks

fouad commented 7 years ago

We're going for a structure similar to zeit/next.js since that seems to be easiest to manage a lot of different types of examples.