search

segmentio / ecs-logs

Log forwarder for services ran by ecs-agent.
MIT License
114 stars 16 forks source link

better event structure #16

Closed achille-roussel closed 8 years ago

achille-roussel commented 8 years ago

@segmentio/infra

This PR changes the log event structure to something that is more common/standard based on what I saw in the loggers I studied. It makes it both easier to integrate and consume log events.

I've also got rid of the cleverness around not duplicating log event data when they already exist in other metadata of the log protocol (syslog, cloudwatch, ...), I think it's better to have the exact same message exist on all platforms. Since I didn't need to set the timestamp to a zero-value anymore I also got rid of the Timestamp type 🎉

screen shot 2016-07-01 at 10 43 53 am screen shot 2016-07-01 at 10 44 02 am

calvinfo commented 8 years ago

Hell yeah. LGTM

achille-roussel commented 8 years ago

Thanks for reviewing!