search

segmentio / emissary

Multi-backend Envoy xDS service.
MIT License
8 stars 7 forks source link

Add admin port and healthcheck route #10

Closed rjenkins closed 5 years ago

rjenkins commented 5 years ago

Additionally in our healthcheck verify we can connect to consul and fetch the current leader, otherwise return 500.

collinvandyck commented 5 years ago

@Pryz so just to confirm, the issue here is that ECS cannot register a task to listen on more than one port?

Pryz commented 5 years ago

@collinvandyck : with ECS/NLB(or ALB) we can only have 1 port per ECS service. So you can't do traffic on one port and healthcheck on another without forcing the host ports.

So here we are going to do that : https://github.com/segmentio/terracode-infra/pull/428/files. This will make the NLB using 9001 for traffic and Registrator will auto discover both ports so we will get the profiles in pprof server.

Downside is that we will not be able to have more than 1 emissary task per instance.

collinvandyck commented 5 years ago

Oh very cool. Thanks @Pryz for the info.