search

segmentio / eslint-config

Segment's ESLint configurations.
9 stars 6 forks source link

yoda should be an error #16

Closed ndhoule closed 8 years ago

ndhoule commented 9 years ago

Warning in the short term to prevent builds from breaking, but eventually should be enabled.

Taken from https://github.com/segmentio/eslint-config/issues/7

stephenmathieson commented 8 years ago

meh.. i think things that cause errors should be errors. stylistic things should be warnings.

stephenmathieson commented 8 years ago

@ndhoule since we've already 3.0.0'ed, should we remove the 2.0.0 milestone :p

/trolling

dominicbarnes commented 8 years ago

I'm ok with stylistic things being errors, because consistency is pretty important imo. I would stick to a warning if we're still migrating a lot of code, or if auto-fixing isn't available.

ndhoule commented 8 years ago

Warnings don't make you fix anything. The longer a warning exists the less value the concept of "warning" as a whole has. Warnings are cool to help you gradually converge on a consistent style, but the body of things that are true warnings should be as small as possible.

Not to mention stylistic consistency is pretty valuable.

ndhoule commented 8 years ago

Resolved in #46