adding some JSX-related config

segmentio / eslint-config

Segment's ESLint configurations.

9 stars 6 forks source link

Closed dominicbarnes closed 9 years ago

dominicbarnes commented 9 years ago

This will require JSX attributes to be single-quoted. (consistency)

It also requires the short-closing tag where available.

/cc @anthonyshort @stevenmiller888 @lancejpollard

anthonyshort commented 9 years ago

I'd vote for double quoted to match our HTML style :)

dominicbarnes commented 9 years ago

Oh really? Haha, I would've assumed single-quotes since it's nested in our JS.

My preference would be for double-quotes as well. Any other votes?

dominicbarnes commented 9 years ago

@anthonyshort I've gone ahead and changed it to use double-quotes instead.

@ndhoule this is ready to merge now.

ndhoule commented 9 years ago

@dominicbarnes meged, new release cut and published

dominicbarnes commented 9 years ago

:boom: Thanks! :D