search

segmentio / eslint-config

Segment's ESLint configurations.
9 stars 6 forks source link

`generator-star-spacing` should not be an error #51

Open stephenmathieson opened 8 years ago

stephenmathieson commented 8 years ago

this super tedious and annoying.. theres no reason for it to fail builds

instead, i think we ought to require 20 spaces (note that that commit is green)

ndhoule commented 8 years ago

Yeah I was looking into this the other day and it seems like eslint doesn't let you require a space only when it's a named generator function, which seems inconsistent with how all their other spacing rules work.

This is also a fixable error by passing --fix to eslint, if your project doesn't already have a fmt make target you should add it, it's useful.

Feel free to PR this (and other quick fixes like this)