#1241 - Possible solution for 2-click re-select on multi-select for Select Menu Component

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment

https://evergreen.segment.com

MIT License

12.39k stars 832 forks source link

#1241 - Possible solution for 2-click re-select on multi-select for Select Menu Component #1247

Closed derekvelzy closed 3 years ago

derekvelzy commented 3 years ago

Overview The isSelected(item) && isMultiSelect condition on line 142 of OptionsList was causing the user to need to click twice to re-select an option on multiselect (per issue #1241). I could not find any example of where this condition was used, but removing it solved this issue.

Screenshots (if applicable) N/A

Documentation

[ ] Updated Typescript types and/or component PropTypes
[ ] Added / modified component docs
[ ] Added / modified Storybook stories

netlify[bot] commented 3 years ago

:heavy_check_mark: Deploy Preview for evergreen-storybook ready!

:hammer: Explore the source changes: 6e7fc7867414a441e2db2b3484b5bb3df52dd744

:mag: Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60e5c33836b60b00082a554e

:sunglasses: Browse the preview: https://deploy-preview-1247--evergreen-storybook.netlify.app

mshwery commented 3 years ago

@derekvelzy thanks for submitting this!! I'm going to close it out in favor of the more complete refactor in the other PR, but thank you for the contribution and pointing out a solution :)