segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Add `rules-of-hooks` to eslint config and fix most ESLint warnings #1251

Closed mshwery closed 3 years ago

mshwery commented 3 years ago

Overview

This PR cleans up our eslint files and adds rule of hooks to eslint. I fixed a few of the warnings, but not all. Some of the warnings require deep changes in the positioner and virtual table components, which my tests resulted in buggy behavior without a larger refactor.

I manually tested all changed components.

Screenshots (if applicable) NA

Documentation

netlify[bot] commented 3 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: c06a7049833578659d04c6d62519d80a82fc321e

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60ef38527cc12c00089a9091

😎 Browse the preview: https://deploy-preview-1251--evergreen-storybook.netlify.app