fix deselect/select on multiple select menus, optimize perf, remove broken context

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment

https://evergreen.segment.com

MIT License

12.39k stars 832 forks source link

fix deselect/select on multiple select menus, optimize perf, remove broken context #1256

Closed mshwery closed 3 years ago

mshwery commented 3 years ago

Overview This PR improves the performance of tables, and the SelectMenu while fixing a buggy behavior when deselecting/reselecting the same item with multiple={true}

Supersedes https://github.com/segmentio/evergreen/pull/1247 and https://github.com/segmentio/evergreen/pull/1142

Screenshots (if applicable) NA

Documentation

[ ] Updated Typescript types and/or component PropTypes
[ ] Added / modified component docs
[ ] Added / modified Storybook stories

mshwery commented 3 years ago

Also resolves https://github.com/segmentio/evergreen/issues/1140 and https://github.com/segmentio/evergreen/issues/1241

netlify[bot] commented 3 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: 4002569a179fb4b1e6b8dffa1985806815267372

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60ef4a49d091d90007673805

😎 Browse the preview: https://deploy-preview-1256--evergreen-storybook.netlify.app

netlify[bot] commented 3 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: 9d65d7fb78db73b56d20406f8eee79c771c64c9c

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60ef5f9b7c15ef0008fda820

😎 Browse the preview: https://deploy-preview-1256--evergreen-storybook.netlify.app