segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Upgrade @types/react to ^17 #1297

Closed zuhair-naqvi closed 1 year ago

zuhair-naqvi commented 3 years ago

Fixes https://github.com/segmentio/evergreen/issues/1291

Overview There's a dependency on "@types/react" which is set to "^16.9.5"

This will force developers to either add "skipLibCheck": true to their ts config OR add a "resolutions" field in order to resolve "duplicate identifier" errors with typescript if the rest of their packages (in a monorepo) use React 17 types

This PR simply drops @types/react from the deps and makes it a responsibility for the consumers.

netlify[bot] commented 3 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: c17193c34062ef55d7ef128a749041282a61132e

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/6115ade55b54ac00081e7ec9

😎 Browse the preview: https://deploy-preview-1297--evergreen-storybook.netlify.app

brandongregoryscott commented 1 year ago

Closing this per https://github.com/segmentio/evergreen/issues/1291#issuecomment-1413791249