search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Info Intent bug on toaster.notify() rectified #1309

Closed hyperloo closed 2 years ago

hyperloo commented 3 years ago

Overview This warning was occurring because info was not provided in the intent's propTypes array. Like in the SS.

I have added 'info' as the Proptype option in all the files wherever required. Here are thee file names:

  1. InlineAlert.js
  2. IconButton.js
  3. CornerDialog.js
  4. Dialog.js
  5. MenuItem.js
  6. TableRow.js
  7. Toast.js

Screenshots (if applicable) From image

To image

Documentation

netlify[bot] commented 3 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: 02e853e11085639bb26f79cd3e8634b2417d82d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/6124e7d40f7f6a00081818de

😎 Browse the preview: https://deploy-preview-1309--evergreen-storybook.netlify.app

brandongregoryscott commented 2 years ago

This shouldn't be an issue now that we've widened the type in all PropTypes calls for intent as well as the TS definitions to string. See https://github.com/segmentio/evergreen/pull/1341.