search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Dialog can not have hasClose when hasHeader is false #1318

Closed kud closed 3 years ago

kud commented 3 years ago

Hello,

Apparently you can not have the close cross when you don't display the header.

However, this is I'd like to have. 😬

pavolmarc commented 3 years ago

Hello, is this still relevant? I would like to work on this issue.

kud commented 3 years ago

It is. :)

pavolmarc commented 3 years ago

@brandongregoryscott hello, can you assign me to this issue, if that's not a problem?

akleiner2 commented 3 years ago

Hi both -

This is intentionally designed - if you pass in hasHeader={false}, the open question becomes where would the cross icon sit? The header argument takes in close as a render prop, so you can implement your alternative header accordingly.

Let me know if this makes sense! Going to close out this issue in the meantime.

kud commented 3 years ago

Ha!

This is exactly why I opened this issue. I didn't want to handle myself the close button when the header isn't displayed. :)