search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Missing intent value 'info' in Menu.Item prop types #1319

Closed polosson closed 3 years ago

polosson commented 3 years ago

Using info as a value for the prop intent of a Menu.item works as expected, but displays a warning in the console, saying that the prop is invalid:

Warning: Failed prop type: Invalid prop `intent` of value `info` supplied to `ForwardRef(MenuItem)`, expected one of ["none","success","warning","danger"].

I think we just need to add this value to this line: https://github.com/segmentio/evergreen/blob/674d9a1d31786e7d00088b8553f353d7fee59732/src/menu/src/MenuItem.js#L165

Maybe it should use a global configuration array of allowed values for this prop?