search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

interface `SidesheetProps` does not match the function signature #1330

Closed larrycustodio closed 3 years ago

larrycustodio commented 3 years ago

The optional prop onBeforeClose for SideSheetProps and OverlayProps should return a boolean value to match their usages and method description:

For SideSheetProps: https://github.com/segmentio/evergreen/blob/0993ac5c17c4820f0ee1cc37ef29c7cefaab2159/index.d.ts#L1842 For OverlayProps: https://github.com/segmentio/evergreen/blob/0993ac5c17c4820f0ee1cc37ef29c7cefaab2159/index.d.ts#L2596

SideSheet.js: https://github.com/segmentio/evergreen/blob/0993ac5c17c4820f0ee1cc37ef29c7cefaab2159/src/side-sheet/src/SideSheet.js#L207

Overlay.js: https://github.com/segmentio/evergreen/blob/0993ac5c17c4820f0ee1cc37ef29c7cefaab2159/src/overlay/src/Overlay.js#L317

brandongregoryscott commented 3 years ago

I should be able to fix this up quick! 😄

akleiner2 commented 3 years ago

Should be fixed by #1340!