Update onBeforeClose prop typing for SideSheet and Overlay components

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment

https://evergreen.segment.com

MIT License

12.39k stars 832 forks source link

Update onBeforeClose prop typing for SideSheet and Overlay components #1340

Closed brandongregoryscott closed 3 years ago

brandongregoryscott commented 3 years ago

Overview

Resolves typing discrepancy for OverlayProps.onBeforeClose and SideSheetProps.onBeforeClose as described in #1330 interface SidesheetProps does not match the function signature

Screenshots (if applicable) N/A

Documentation

[x] Updated Typescript types and/or component PropTypes
[x] [N/A] Added / modified component docs
[x] [N/A] Added / modified Storybook stories

netlify[bot] commented 3 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: 6094b810d292b3ebecd403ba0a5f1e5358319075

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/615ba28138eb360008f26fb9

😎 Browse the preview: https://deploy-preview-1340--evergreen-storybook.netlify.app