Closed kamebkj closed 2 years ago
✔️ Deploy Preview for evergreen-storybook ready!
🔨 Explore the source changes: 6fcee8d2230dd5c4bda4bb5acc881201d09c99b4
🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/619d1fa4fc90520008107c59
😎 Browse the preview: https://deploy-preview-1344--evergreen-storybook.netlify.app
I forgot this PR is still opened. Thought I've merged it months ago 😅 . Thanks for the eyes on this!!
Basic tests for the components but would love some guidance on a few parts:
size
prop for bothRadio
andRadioGroup
since the size is applied on the sibling element of theinput[type=radio]
. The size of theinput
element itself is always 1pxRadioGroup
the propisRequired
is adding therequired
state to all the options in its group. I have a test case to test their states but unsure why we have this prop in the first placedefaultValue
prop inRadioGroup
so didn't write a test for itThanks!