correctly forward className in code component

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment

https://evergreen.segment.com

MIT License

12.39k stars 832 forks source link

correctly forward className in code component #1352

Closed salolivares closed 2 years ago

salolivares commented 3 years ago

Overview

This PR changes the order the props are spread in <Code> so className is correctly forwarded.

Fixes #1351

Screenshots (if applicable)

Before: Screen Shot 2021-10-29 at 10 32 33 AM

After: Screen Shot 2021-10-29 at 10 32 54 AM

Documentation

[ ] Updated Typescript types and/or component PropTypes
[ ] Added / modified component docs
[ ] Added / modified Storybook stories

netlify[bot] commented 3 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: e2d63e0c18d397819fb2b887b4ca8375077913a0

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/618179f0a8d3510007c6607a

😎 Browse the preview: https://deploy-preview-1352--evergreen-storybook.netlify.app

salolivares commented 3 years ago

Thanks for fixing this up so quickly! If you have some time, would you mind adding a test case for this? We've been trying to add more coverage - this would be a great case to add since we're fixing a bug 😄

There should be some examples to go off of in Textarea.test.js or TextInput.test.js

Will do 👍