Closed brandongregoryscott closed 2 years ago
βοΈ Deploy Preview for evergreen-storybook ready!
π¨ Explore the source changes: 2f651715ee12cefd01714f2b1be58157c8203e1e
π Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/619410e72133fc00072bb3cd
π Browse the preview: https://deploy-preview-1362--evergreen-storybook.netlify.app
Overview
Fixes #1354 Combobox position issue Fixes #1329 Autocomplete 'children' function continuously invoked
The root issue for #1329 was not the ref updates but the
useEffect
insrc/positioner/src/Positioner.js
. It was watchingdimensions
as a dependency while it was usingpreviousDimensions
and also callingupdate
, which wasn't wrapped in auseCallback
. This should only re-render when those values change. Tested out in storybook using the same console log in the children function as described in #1329Screenshots (if applicable)
Autocomplete rendering before
Positioner
change https://www.loom.com/share/353e9a69b7f744d2816bcdab7aff8ddaAutocomplete rendering after
Positioner
change https://www.loom.com/share/6f9963d7966046fdbd579ea2e3565a35Note that both of these are after the
ref
changes inAutocomplete
andCombobox
were reverted, so those are appearing in the correct location.Combobox positioning (also demoable from Storybook)
Autocomplete positioning (also demoable from Storybook)
Documentation