Closed brandongregoryscott closed 2 years ago
@brandongregoryscott can I start working on this issue?
Hi @brandongregoryscott I would like to contribute to this issue but as i am beginner in opensource contribution. I am not able to start the project in my local machine. 1- I forked it. 2- Run npm install But as i looked in package.json file the "start" is missing in the scripts and i am not able to resolve this issue. Please help me out.
@brandongregoryscott can I start working on this issue?
@Gulshanaggarwal Of course - feel free to open up a PR!
@vikasazad Please refer to step 2 in the contributing section: https://github.com/segmentio/evergreen/#-step-2-get-storybook-up-and-running
While you can use npm
, we have set up the project to prefer yarn
. The command for running a local development server would be yarn dev
or npm run dev
.
@vikasazad sorry to say, but I'm already working on the above issue.
@brandongregoryscott If I apply borderBottomLeftRadius prop inside table.row then it causes the rounded border to all elements, see the below image-
Can you help little bit more?
@Gulshanaggarwal ok no problem at all
There are some minor styling issues with the base
Table
styles, which can be observed on the documentation site (may need to Zoom in to see them): https://evergreen.segment.com/components/tableInner content of
Table.Head
is missingborderTopLeftRadius
andborderTopRightRadius
style to match its outer container, which causes a sharp edge to render over the rounded borderLast
Table.Row
is missingborderBottomLeftRadius
andborderBottomRightRadius
style to match its outer container, which causes a sharp edge to render over the rounded borderLast
Table.Row
has aborderBottom
style which is overlapping with the bottom border of the outer container causing a thicker border