segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Table border styling issues #1375

Closed brandongregoryscott closed 2 years ago

brandongregoryscott commented 2 years ago

There are some minor styling issues with the base Table styles, which can be observed on the documentation site (may need to Zoom in to see them): https://evergreen.segment.com/components/table

Gulshanaggarwal commented 2 years ago

@brandongregoryscott can I start working on this issue?

vikasazad commented 2 years ago

Hi @brandongregoryscott I would like to contribute to this issue but as i am beginner in opensource contribution. I am not able to start the project in my local machine. 1- I forked it. 2- Run npm install But as i looked in package.json file the "start" is missing in the scripts and i am not able to resolve this issue. Please help me out.

brandongregoryscott commented 2 years ago

@brandongregoryscott can I start working on this issue?

@Gulshanaggarwal Of course - feel free to open up a PR!

@vikasazad Please refer to step 2 in the contributing section: https://github.com/segmentio/evergreen/#-step-2-get-storybook-up-and-running

While you can use npm, we have set up the project to prefer yarn. The command for running a local development server would be yarn dev or npm run dev.

Gulshanaggarwal commented 2 years ago

@vikasazad sorry to say, but I'm already working on the above issue.

Gulshanaggarwal commented 2 years ago

@brandongregoryscott If I apply borderBottomLeftRadius prop inside table.row then it causes the rounded border to all elements, see the below image- Screenshot (241)

Can you help little bit more?

vikasazad commented 2 years ago

@Gulshanaggarwal ok no problem at all