Closed brandongregoryscott closed 2 years ago
βοΈ Deploy Preview for evergreen-storybook ready!
π¨ Explore the source changes: d2c9179a92fc4d63493b908a515c3e40a291c424
π Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/61fbe1172eaeb200075be48f
π Browse the preview: https://deploy-preview-1387--evergreen-storybook.netlify.app
Overview
Adds
yarn tsd
to theyarn test
script so we can actually leverage theindex.test-d.ts
in CI (or ifyarn test
is run manually). I added some additional tests and intentionally changed a type to{}
to fail the build on my fork: https://github.com/brandongregoryscott/evergreen/runs/4819588995?check_suite_focus=trueUpdated
ci.yml
so that the build steps will run on any branch push, not justmaster
. If workflows are enabled on your fork, this should give you some quicker feedback on whether the CI build will pass on a pull request.The
DefaultTheme.components.<Component>.baseStyle
type should have been aPartial
to matchappearances
,sizes
, and theTheme
baseStyle type.Finally, per request, I widened the
colors
theme property andColors
type to includestring[]
. We don't have any use-cases for it that I know of, but it doesn't clobber any of the typing as far as I can tell, so it should be safe to use.Screenshots (if applicable)
Documentation