segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

added buttons and icons #1401

Closed SamanjaCartagena closed 2 years ago

SamanjaCartagena commented 2 years ago

Overview I have added some buttons in the buttons section and a few icons that were missing. I added the print button with the icon, the export button with the icon and the chat button with a chat icon. I added stories for the button, by adding new buttons and added some much needed icons by using the blueprint icons. All my changes are in index.stories.js. All the icons have been taken from the icons section, generated icons.

Screenshots (if applicable)

addedButtons

Documentation

netlify[bot] commented 2 years ago

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: db8b6a88bf942d2fbaa983a37aac76959a31fbac

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/61ff475083ea5b00078b0397

😎 Browse the preview: https://deploy-preview-1401--evergreen-storybook.netlify.app

brandongregoryscott commented 2 years ago

Hi @SamanjaCartagena,

While we appreciate the effort, our Storybook isn't necessarily meant to be an exhaustive list of all possible icons/appearances/sizes/etc., but moreso to serve as a development tool and playground for showcasing new or updated component functionality. We already have all of the available icons documented with a search input on our doc site here, so I don't think we really need to tack on a handful more to our Button stories.