search

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment
https://evergreen.segment.com
MIT License
12.39k stars 832 forks source link

Switch to new faker #1425

Closed Shinigami92 closed 2 years ago

Shinigami92 commented 2 years ago

Overview

Update faker dependency

Related to https://github.com/faker-js/faker/issues/542

Screenshots (if applicable)

Documentation

Shinigami92 commented 2 years ago

Please run the CI tests so we can see if everything works I will come back and update to released version when it's out

brandongregoryscott commented 2 years ago

Hey @Shinigami92 - thanks for your contribution! My apologies - I should've assigned that issue to myself, I pushed out a PR over the weekend to take care of it (#1421) - it looks like we needed to upgrade to node 14, too.

The changes look pretty similar aside from the direct import of the en locale in your PR - was this intentional or can the import stay as @faker-js/faker?

Shinigami92 commented 2 years ago

Oh it's my fault that I didn't checked that there is already an issue / a PR. I think I will close this PR and we should move on in the other already existing PR