Add window resize handler to update position in Positioner component

segmentio / evergreen

🌲 Evergreen React UI Framework by Segment

MIT License

12.39k stars 832 forks source link

Overview

Some users are reporting an issue with our Popover component not being visible when they resize their browser windows. This can be reproduced on Storybook or the doc site.

This PR adds a window.resize event listener in the Positioner component which forces it to recalculate its position when the window size changes. It seems to solve the issue (a Popover being hidden when the browser is resized to be smaller), but I'm not sure if there's a cleaner/more efficient way to handle this. (Do I need to use request/cancelAnimationFrame? Should we debounce it?)

Screenshots (if applicable)

Documentation

[ ] Updated Typescript types and/or component PropTypes
[ ] Added / modified component docs
[ ] Added / modified Storybook stories

segmentio / evergreen

Add window resize handler to update position in Positioner component #1426